-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reupload #323
feat: reupload #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, regarding to the axiosOptions on module level we can provide this additionally but I also don't see real any use-case now for that now.
for the Bee issue I'd rather propose using 422 http error, as the syntax and the request are in great format and understandable by the "server", but the business-logic does not let reupload an unpinned content.
@nugaon you mean for this reupload endpoint or generally in Bee JS?
Hmm not sure how it is related to this? I would suggest to comment in the linked issue as this is up to the Bee team to decide |
I meant I don't see the use-case for this reupload endpoint regarding to the axios options. anyway it can be unified as in our other modules we do the same, it doesn't pollute the code. |
it was commented in your code in this PR. |
Closes #313